Skip to content

make output of rijn example a bit nicer#815

Merged
janvanrijn merged 1 commit intoopenml:developfrom
amueller:rijn_example_cleanup
Oct 16, 2019
Merged

make output of rijn example a bit nicer#815
janvanrijn merged 1 commit intoopenml:developfrom
amueller:rijn_example_cleanup

Conversation

@amueller
Copy link
Copy Markdown
Contributor

Slightly nicer output for 2018 kkd rijn example

@mfeurer mfeurer requested a review from janvanrijn October 14, 2019 09:42
@mfeurer
Copy link
Copy Markdown
Collaborator

mfeurer commented Oct 14, 2019

I think @janvanrijn should approve this.

@janvanrijn
Copy link
Copy Markdown
Member

Not sure if this is an improvement, there might be a lot of issues with tailing brackets?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 14, 2019

Codecov Report

Merging #815 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
- Coverage    87.71%   87.69%   -0.03%     
===========================================
  Files           36       36              
  Lines         4234     4234              
===========================================
- Hits          3714     3713       -1     
- Misses         520      521       +1
Impacted Files Coverage Δ
openml/_api_calls.py 83.11% <0%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cd94b...24c4821. Read the comment docs.

@amueller
Copy link
Copy Markdown
Contributor Author

Can you explain? This hides the package and module name (and a repeated type output that adds lots of output to the example and doesn't really say anything).

Copy link
Copy Markdown
Member

@janvanrijn janvanrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad, it works

@janvanrijn janvanrijn merged commit 17657ab into openml:develop Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants